search

marckunze / rancor

Ranked Choice voting tool repo
https://rancor.herokuapp.com
Other
0 stars 0 forks source link

User Authentication and creation #16

Closed marckunze closed 9 years ago

marckunze commented 10 years ago

Need to create a page and method for authenticating users.

marckunze commented 9 years ago

Assigning to @MarkHammondJr since he's already been working on this already. And see #21 for some other comments about the whole thing.

marckunze commented 9 years ago

Also just noting that this includes basic user add and login. Although that should be fairly obvious.

marckunze commented 9 years ago

Hey @MarkHammondJr do we just need to validate that this works on the local and on staging now? 203c5d0125a4a5594b2d1f1f3089ac303a333ff1

MarkHammondJr commented 9 years ago

I checked that it was working in staging during class, but double checking before moving on is always a good idea.

marckunze commented 9 years ago

This one looks good, I'm closing, thanks.

dennisccsf commented 9 years ago

was using new_user.erb to work on some styling 8281fbfc644b7bbbd594702bc3b0a05ffd91551f during the process, found out user account can be created without a password. consequently, login can be made without password. is this a feature or a bug?... can fix easily with required attribute but just wondering.

MarkHammondJr commented 9 years ago

I saw that too but I keep forgetting to change it.

MarkHammondJr commented 9 years ago

As of https://github.com/marckunze/rancor/commit/ebdd813ea4b4804a2658895f38e97f796a1a0266 this is no longer a oversight. it's an intentional choice for the purpose of testing.