search

marckunze / rancor

Ranked Choice voting tool repo
https://rancor.herokuapp.com
Other
0 stars 0 forks source link

Clean up code styling #31

Closed marckunze closed 9 years ago

marckunze commented 9 years ago

This came up from @MarkHammondJr commit db85198966b40baa4feb24bc8f6af45e34724bec but we may want to clean up our code styling to be consistent. Not sure what style guide he was using, but we may want to clean up to match. So what style do we want to use? Github's? or some other one? https://github.com/styleguide/ruby

MarkHammondJr commented 9 years ago

I was using this styleguide, which is the styleguide that the github styleguide was adapted from.

marckunze commented 9 years ago

Ok. When we do a final cleanup we can make sure everything is fairly consistent based on that. Thanks.

MarkHammondJr commented 9 years ago

When do we want to start the "final cleanup?"

I can do it real quick no problem. I have mastered the art of retabbing (using 4 characters in vim).

marckunze commented 9 years ago

I would say once we've closed out the minimum viable. it's not going to kill us. Just a nice to have as long we're consistent

marckunze commented 9 years ago

@MarkHammondJr you ok to close this one out? It looks ok to me when I run the rubocop linter, but just wanted to confirm.

MarkHammondJr commented 9 years ago

I'm ok with it.