search

marckunze / rancor

Ranked Choice voting tool repo
https://rancor.herokuapp.com
Other
0 stars 0 forks source link

Implement Sass and compass? #48

Open marckunze opened 9 years ago

marckunze commented 9 years ago

This came up while I was looking at a few recent commits as well as the custom color scheme and others.#23 Do we want to change some of the css and html structuring to be closer to https://github.com/bergcloud/example-sinatra-site with compass and the bootstrap gem handling the css. Not sure if implementing this would be any easier than our current setup.

dennisccsf commented 9 years ago

is the in-line css causing a problem?

marckunze commented 9 years ago

Not sure, but after 3b5452ede93212edfb0b090a4579d131b6a1f2b0 it doesn't appear to work. When I tried to adjust to make both dropdowns and sortable polls working. So I don't think it's the inline css, but likely the javascript. I'm not sure what is going on there on how to fix both, and how to add in custom js that would work. I tagged it in the voting page #25

ghost commented 9 years ago

Let's not change the css and html yet. I'm working on modifying #23 to find an easier way for it. I'm still not sure on how, I might include custom error messages (with if & else) for each unique errors! I don't know if this is a good idea yet, I still have to work on it.

On Sun, Nov 23, 2014 at 11:48 PM, Marc Kunze notifications@github.com wrote:

This came up while I was looking at a few recent commits as well as the custom color scheme and others.#23 https://github.com/marckunze/rancor/issues/23 Do we want to change some of the css and html structuring to be closer to https://github.com/bergcloud/example-sinatra-site with compass and the bootstrap gem handling the css. Not sure if implementing this would be any easier than our current setup.

— Reply to this email directly or view it on GitHub https://github.com/marckunze/rancor/issues/48.

MarkHammondJr commented 9 years ago

error messages for what?

ghost commented 9 years ago

page not found I'm assuming that we are handling the incorrect e-mail entries and such through html...

On Mon, Nov 24, 2014 at 12:31 AM, MarkHammondJr notifications@github.com wrote:

error messages for what?

— Reply to this email directly or view it on GitHub https://github.com/marckunze/rancor/issues/48#issuecomment-64163956.

marckunze commented 9 years ago

Moving this one to slop/final polish. If there's time maybe we can properly load in bootstrap as sass with compass, etc. But for now the static css should be ok.

marckunze commented 9 years ago

Doubt there will be time to fix, unless this causes a user facing issue not going to fix.