marcmenem / ggshadow

A collection of geoms for R's 'ggplot2' library. geom_shadowpath(), geom_shadowline(), geom_shadowstep() and geom_shadowpoint() functions draw a shadow below lines to make busy plots more aesthetically pleasing. geom_glowpath(), geom_glowline(), geom_glowstep() and geom_glowpoint() add a neon glow around lines to get a steampunk style.
GNU General Public License v2.0
60 stars 5 forks source link

No issue, but would love to see additional geoms #1

Closed davisj2007 closed 3 years ago

davisj2007 commented 3 years ago

Love this package, particularly since a plotting style I use is very "retro" heavy. i tried to back into a geom_point replicating your overall glow aesthetic, but can't figure it out. What would it take to produce a geom_point, geom_bar, etc version?

Thanks again, love the work

marcmenem commented 3 years ago

Thank you for the compliment.

I have only used geom_shadowline and geom_shadowpoint for "real life" work, I added the glow as a fun experiment, happy to see that someone found it useful, and I would love to see example charts using it.

Here is where I got the inspiration: https://matplotlib.org/matplotblog/posts/matplotlib-cyberpunk-style/

It wouldn't take a lot of effort to build a glowpoint. I will look into it when I have some free time.

I am not sure what you are trying to achieve with geom_bar, do you have example charts of what you have in mind? I haven't looked into the internal of ggplot for other geoms.

davisj2007 commented 3 years ago

I also use geom_shadowline more for "real" life (I got tired of building hacking my own version and I'm not a very good developer, which led me to you) but love "glow" for my personal work. I use a very "neon"-esque plotting theme, and the glow geoms really make it pop (https://twitter.com/davisj2007/status/1344667510566744065?s=20)

I have no specific examples of additional geoms I'd be interested in, outside of keeping my private work as 80s cyberpunk as possible 👍 Thanks again!

davisj2007 commented 3 years ago

image

marcmenem commented 3 years ago

Just added geom_glowpoint. I am thinking of adding a shaded area below lines and glowing lolipops and dumbbell should be easy as well.

davisj2007 commented 3 years ago

This is great! Exactly what I was looking for and love. Thanks again for quick response and keep up the work (btw, we're transitioning from my hacky shadowlines to your much easier to implement version :) )

marcmenem commented 3 years ago

Hi Jake, happy to hear this is useful, your comment was the impulse I needed to put in the effort to submit to CRAN. I will wait for more feedback before adding new geoms.