search

marcmenem / ggshadow

A collection of geoms for R's 'ggplot2' library. geom_shadowpath(), geom_shadowline(), geom_shadowstep() and geom_shadowpoint() functions draw a shadow below lines to make busy plots more aesthetically pleasing. geom_glowpath(), geom_glowline(), geom_glowstep() and geom_glowpoint() add a neon glow around lines to get a steampunk style.
GNU General Public License v2.0
60 stars 5 forks source link

Issues with next version of ggplot2 #3

Closed thomasp85 closed 2 years ago

thomasp85 commented 2 years ago

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that your package somehow includes references to ggplot2 code from when it was build, either by reloading saved plot objects or by grabbing functions at build time. Please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/ for some more info about why this can cause issues.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards Thomas

marcmenem commented 2 years ago

Thank you for letting me know. It looks like the issue is due to using the new_data_frame function from ggplot2 using the getFromNamespace function. A simple fix seems to be to replace ggplot2 with vctrs. I will test the change and try to release a new version.

#new_data_frame <- getFromNamespace("new_data_frame", "ggplot2")
new_data_frame <- getFromNamespace("new_data_frame", "vctrs")
marcmenem commented 2 years ago

solved by with ggshadow 0.0.4