search

marcmenem / ggshadow

A collection of geoms for R's 'ggplot2' library. geom_shadowpath(), geom_shadowline(), geom_shadowstep() and geom_shadowpoint() functions draw a shadow below lines to make busy plots more aesthetically pleasing. geom_glowpath(), geom_glowline(), geom_glowstep() and geom_glowpoint() add a neon glow around lines to get a steampunk style.
GNU General Public License v2.0
60 stars 5 forks source link

Update DESCRIPTION + complete additional fix for shadowsize parameter #6 #9

Closed elipousson closed 1 year ago

elipousson commented 1 year ago

In the process of adding myself as a contributor, I spotted a use of shadowsize in the README. When I fixed it, I realized that if shadowsize was passed as a variable with aes() it wasn't handled correctly and didn't get passed on to shadowlinewidth. So this pull request also more fully completes #6 as well as some minor updates to the NEWS.md file and function docs that didn't get pulled into the last PR.

marcmenem commented 1 year ago

thank you again for this.

elipousson commented 1 year ago

Happy to do it! If you needed any helping updating on CRAN, feel free to assign me an issue. Now that I know where most everything is internally, I'd be glad to help when I have time.