Off-by-one error in getGIFFilenameByIndex

marcmerlin / AnimatedGIFs

Animated GIFs on Teensy, ESP8266, ESP32 on top of FastLED::NeoMatrix, SmartMatrix::GFX, and SmartMatrix, using Sdcard, SPIFFS, and FatFS (FFAT)

MIT License

68 stars 12 forks source link

Closed rorosaurus closed 3 years ago

rorosaurus commented 4 years ago

This error is why the last alphabetically gif is always index 0, then after that the filename indexes descend as expected.

I'm not sure if this affects the other targets, but I'll put out a quick PR for ESP32.

marcmerlin commented 4 years ago

thanks Rory. I'm on a dive boat, so I can't easily look at this right now, but definitely will, and it seems your fix should work.

rorosaurus commented 4 years ago

No rush! Be safe and enjoy, Marc!

marcmerlin commented 3 years ago

oops, I fixed this, but never closed it, sorry