search

marcmerlin / FastLED_NeoMatrix

Adafruit GFX compatible library for NeoPixel based Matrices using FastLED library
GNU General Public License v3.0
193 stars 50 forks source link

Don't accidentally build gamma tool when building a sketch #2

Closed benpicco closed 5 years ago

benpicco commented 5 years ago

Some build systems are lazy efficient and will just try to build every source file they can find in the library folder. Let's do the same as Adafruit-GFX and not compile the tool code when building for Arduino, to avoid ending up with two main() methods.

marcmerlin commented 5 years ago

Interesting, didn't know about this. The gamma tool actually came from Adafruit::NeoMatrix, so there is likely the same problem there, but I included this here, thanks.

benpicco commented 5 years ago

Well maybe it's just my build system that does that, thank you regardless! :smile:

marcmerlin commented 5 years ago

Gotcha. Either way, no harm in adding your patch. When I get a chance, I'll look at your simulator, looks cool :)

marcmerlin commented 5 years ago

@benpicco by the way, if you want a big stress test as well as a bunch of 64x64 demos for your simulator, see if you can get https://github.com/marcmerlin/NeoMatrix-FastLED-IR working. It would be impressive if it works in a simulator.