search

marco-c / autowebcompat

Automatically detect web compatibility issues
Mozilla Public License 2.0
34 stars 41 forks source link

force_single_line configuration for isort #190

Closed Shashi456 closed 6 years ago

Shashi456 commented 6 years ago

Fixes #189.

marco-c commented 6 years ago

There are still some flake8 failures (see Travis logs)

Shashi456 commented 6 years ago

@marco-c i will revise the errors, i directly executed isort on my terminal and it seems to have rearranged the files in an inappropriate way

codecov-io commented 6 years ago

Codecov Report

Merging #190 into master will increase coverage by 0.83%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   20.29%   21.13%   +0.83%     
==========================================
  Files          11       11              
  Lines        1143     1164      +21     
  Branches      147      147              
==========================================
+ Hits          232      246      +14     
- Misses        909      916       +7     
  Partials        2        2
Impacted Files Coverage Δ
pretrain.py 0% <0%> (ø) :arrow_up:
train.py 0% <0%> (ø) :arrow_up:
collect.py 0% <0%> (ø) :arrow_up:
tests/test_utils.py 100% <100%> (ø) :arrow_up:
autowebcompat/utils.py 44.55% <100%> (+0.55%) :arrow_up:
autowebcompat/network.py 20.21% <100%> (+5.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b860f0...d6b11d6. Read the comment docs.

propr[bot] commented 6 years ago

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.