Write locations of all elements on a webpage.

[sagarvijaygupta]

Solves #238 partially

[sagarvijaygupta]

@marco-c This will slow down the crawler. Implementing it separately may lead to inconsistency as in that case, what xpert will do won't be at the same time when we have screenshots for.

[marco-c]

I think this looks good (after you remove the debugging code)! The number of mismatches is reasonably small.

[sagarvijaygupta]

@marco-c Since we require this location part only for xpert and I don't think we will be running xpert for all the websites for which we will be running our models, do you feel that we need location files for all? Or should we just create a test folder where we will be having location files for few websites only.

In that case I think we should provide an argparse interface or something similar so that we don't unnecessarily run it for all.

[codecov-io]

Codecov Report

Merging #239 into master will decrease coverage by 0.53%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   23.05%   22.52%   -0.54%     
==========================================
  Files          11       11              
  Lines        1301     1332      +31     
  Branches      179      184       +5     
==========================================
  Hits          300      300              
- Misses        999     1030      +31     
  Partials        2        2

Impacted Files	Coverage Δ
collect.py	0% <0%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c868cc...a9602ae. Read the comment docs.

[propr[bot]]

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.