search

marco-c / autowebcompat

Automatically detect web compatibility issues
Mozilla Public License 2.0
34 stars 41 forks source link

test_labels.py is not actually testing the screenshots actually exist #245

Closed sagarvijaygupta closed 6 years ago

sagarvijaygupta commented 6 years ago

https://github.com/marco-c/autowebcompat/blob/9dd4b2b38025920324ba0bbcb45fe307a51bdf72/tests/test_labels.py#L10

Should be changed to

os.path.exists(os.path.join('data', '{}_{}.png'.format(label, browser)))

sagarvijaygupta commented 6 years ago

5478_4 5478_4 5991 6081_3 6081_3 7490_4 7490_4 8371 8371 9084_6 9084_6 @marco-c these labels are present in your csv file but not uploaded in gitlab

marco-c commented 6 years ago

@marco-c these labels are present in your csv file but not uploaded in gitlab

Ah yes, it's because I have some additional screenshots on my machine that I haven't pushed yet...

marco-c commented 6 years ago

Since they are just a few, would you mind removing them manually as part of https://github.com/marco-c/autowebcompat/pull/246?