marco-c / autowebcompat

Automatically detect web compatibility issues
Mozilla Public License 2.0
34 stars 41 forks source link

Label 2500+ images #248

Closed amaaniqbal closed 6 years ago

amaaniqbal commented 6 years ago

Labelled 2562 images.

codecov-io commented 6 years ago

Codecov Report

Merging #248 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   23.05%   23.05%           
=======================================
  Files          11       11           
  Lines        1301     1301           
  Branches      179      179           
=======================================
  Hits          300      300           
  Misses        999      999           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 896b658...8a127f2. Read the comment docs.

marco-c commented 6 years ago

It looks like your labels are not sorted, could you: 1) Rebase on top of master; 2) Label one more case, so that the labels get sorted; 3) Run generate_labels.py

amaaniqbal commented 6 years ago

git rebase master is returning everything up to date

What do you mean by label one more case?

marco-c commented 6 years ago

git rebase master is returning everything up to date

You need to run: git pull upstream master --rebase

What do you mean by label one more case?

Label just another couple of screenshots, so the label.py script will automatically sort them in the CSV file.

amaaniqbal commented 6 years ago

Should I run the git pull upstream master --rebase command on the current branch or master.

sagarvijaygupta commented 6 years ago

@amaaniqbal In your current branch

propr[bot] commented 6 years ago

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.