search

marco-c / autowebcompat

Automatically detect web compatibility issues
Mozilla Public License 2.0
34 stars 41 forks source link

Limit size of full page screenshot #250

Open sagarvijaygupta opened 6 years ago

sagarvijaygupta commented 6 years ago

Some webpages are extremely big. Some like quora or linkedin come with infinite scroll. We should keep a limit on it.

Shashi456 commented 6 years ago

Is there a way to detect infinite scroll in a website ? I think if you keep a limit on the screenshot there may be some sites which are just long pages but don't get the entire image because of the limit.

Another approach could be whitelisting sites ,like having a case that if the website is quora or LinkedIn or Facebook then the limit could kick in.

sagarvijaygupta commented 6 years ago

Infinite website is just a concern. Generally it starts loading when we reach very end (what I have noticed experimentally). So height provided is its initial height. Just wanted to make sure they don't create a problem.

marco-c commented 6 years ago

We can put a sane limit, it's OK if we don't get all possible images for a website.

sagarvijaygupta commented 6 years ago

We actually want it: This happened now for Testing https://planet.mozilla.org/ (bug 10256) in firefox I got more than 4832 images (all white and blank)