sdv4 commented 5 years ago

Fixes #280 The problem was fixed by removing the creation of an array containing a vector for every image file in utils.py/get_ImageDataGenerator. The code was there in preparation for a call to fit() for the ImageGenerator object. Upon inspecting the documentation for this method, it turns out that this call was not necessary for the image processing we are doing.

I tested this on Colab for a few epochs on vgg16 using imagenet weights.

codecov-io commented 5 years ago

Codecov Report

Merging #282 into master will decrease coverage by 0.17%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   15.72%   15.54%   -0.18%     
==========================================
  Files          13       13              
  Lines        1889     1885       -4     
  Branches      328      327       -1     
==========================================
- Hits          297      293       -4     
  Misses       1590     1590              
  Partials        2        2

Impacted Files	Coverage Δ
autowebcompat/utils.py	`49.54% <ø> (-0.9%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eea0ba4...1bebfc4. Read the comment docs.

marco-c commented 5 years ago

@sdv4 why did you open a new PR?

marco-c / autowebcompat

Fix for OOM issue while running in Colab #282

Codecov Report