marco-calautti / DeltaPatcher

Delta Patcher is a GUI software that is able to create and apply xdelta patches.
GNU General Public License v2.0
265 stars 30 forks source link

An error has occurred: xdelta3: target window checksum mismatch: XD3_INVALID_INPUT #22

Closed delta0890 closed 8 months ago

delta0890 commented 1 year ago

so basically i tried patching pizza tower scoutdigo data.win with soundigo.xdelta it doesn't work, it just logs [8:48:07 PM] An error has occurred: xdelta3: target window checksum mismatch: XD3_INVALID_INPUT

marco-calautti commented 1 year ago

I am sorry to be rude, but I am tired of explaining for the 1000th time what that error means. That is not a problem with Delta Patcher. There are plenty of closed issues here in github discussing this error message, which has exclusively to do with the patch you are using not being applied to the right ROM. Even googling for the error message will give you the answer you are looking for in the first 2-3 websites.

Use Google!! https://www.google.com/search?q=xd3_invalid_input&oq=xd3_invalid_input&aqs=heirloom-srp..0l5

ElektroStudios commented 8 months ago

Suggestion: catch that error id. XD3_INVALID_INPUT and translate the error message into something more... human readable or understandable, like for example a mix with the words you've said: Checksum mismatch: XD3_INVALID_INPUT (the patch you are using is not being applied to the right ROM)

The error message target window checksum mismatch: XD3_INVALID_INPUT is too technical, it is incomprehensible for any user without enough understanding, one must try to figure out what the error really means by searching the Internet on sites like this...

It is understandable that most people fall into the same doubt when this error occurs... the original author of xdelta constructed that error message in a way that is unhelpful to end users.

You have the opportunity to improve original author's error messages in your own GUI.

By the way, great job with this tool.

marco-calautti commented 8 months ago

Yes, that is an improvement I had in mind to implement. Since I have some free time during this period, I might try to implement that.

marco-calautti commented 8 months ago

Latest release of Delta Patcher now provides a better message when the input file is wrong!