marco-land / sanity-plugin-vimeo-field

Retrieve Vimeo video data via the API with an access token and store it in Sanity.
MIT License
11 stars 1 forks source link

Integrate Sanity Studio Secrets? #1

Open AllanPooley opened 8 months ago

AllanPooley commented 8 months ago

Hey Marco,

Thanks for building this - I know more than one person that would find this enhancement super useful (myself included).

This plugin popped up on #i-made-this on the Sanity Slack Channel (that's how I found it). I could be wrong, but it looks like you're not a member there. Just thought I'd pass on a comment / suggested from Knut Melvær (dev rel @ Sanity)

This is great! Btw, I’d look into integrating https://github.com/sanity-io/sanity-studio-secrets so that folks don’t need to embed the access token in the (public) Studio JS bundle.

marco-land commented 8 months ago

Hi Allan,

Thanks for your feedback and for passing on Knut's comment -- I wouldn't have seen that and will also be joining the Slack community.

Knut's comment is a good idea and I will implement it in the next release 🙂

intelligence commented 3 months ago

Any progress on this?

marco-land commented 2 months ago

Yes and no. I've put this on hold because the sanity studio secrets had issues which have been resolved in the meantime but I did not have time to work on this yet. I will try and add it soon though.

intelligence commented 2 months ago

Thanks Marco! Sorry for stressing. I've had issues to get the plugin to pickup from .env files so I'm currently putting the key right within the config, thus I was wondering :)