search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
460 stars 109 forks source link

NuGet updates (StackExchange.Redis most importantly) #119

Closed soenneker closed 1 year ago

soenneker commented 1 year ago

Various cleanup Tests are no longer parallelized NET461 -> NET462 (no longer supported)

After trying to run the tests it became apparently that there are issues with the global locking between tests (CleanRedis attribute). This seems to be some workaround instead of properly using a fixture?

soenneker commented 1 year ago

Test is getting stuck on that one nested lock - it looks like it was failing before my changes.

marcoCasamento commented 1 year ago

You’re right that damn test used to fail sometimes, but I’ve never been able to solve that problem.

Thanks for your effort, I’m going to merge the PR

From: Jake Soenneker @.> Sent: giovedì 2 marzo 2023 02:03 To: marcoCasamento/Hangfire.Redis.StackExchange @.> Cc: Subscribed @.***> Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] NuGet updates (StackExchange.Redis most importantly) (PR #119)

Test is getting stuck on that one nested lock - it looks like it was failing before my changes.

— Reply to this email directly, view it on GitHub https://github.com/marcoCasamento/Hangfire.Redis.StackExchange/pull/119#issuecomment-1451120992 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AABW2Y5C45CIP3472JNMMLTWZ7WTVANCNFSM6AAAAAAVMI2FCI . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AABW2Y6TT42GNWUDIWIIAQ3WZ7WTVA5CNFSM6AAAAAAVMI2FCKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWPZMWA.gif Message ID: @. @.> >