search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
456 stars 109 forks source link

Dictionary case sensitive comparison fix #19

Closed VictorTomaili closed 8 years ago

VictorTomaili commented 8 years ago

There is solution for my issue. Fixed #18

VictorTomaili commented 8 years ago

Ohh, thats CI build fails not mine :smile:

marcoCasamento commented 8 years ago

I Know, sorry for that! I'll try to fix it tomorrow and review your PR too, thanks!! good night

marcoCasamento commented 8 years ago

It now builds on windows, see (https://ci.appveyor.com/project/marcoCasamento/hangfire-redis-stackexchange/build/1.0.95) but your PR seems to fail on some tests, due to type loading errors. Nuget dependency update needs a bit more work than simply changing packages.config, but it's already done on dev branch (I plan to merge it this weekend), could you remove the packages config and try again ? (or, if you need the packages update right now, make the PR toward dev branch)

VictorTomaili commented 8 years ago

i revert nuget update temporary.

marcoCasamento commented 8 years ago

Ok great, I've tried locally and it works.PR just merged and nuget package published. Thanks