search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
456 stars 109 forks source link

Nuget package dependencies #21

Closed zlangner closed 7 years ago

zlangner commented 8 years ago

HangFire.Core is dependent on Newtonsoft.Json >= 5.0.0. Why is this package dependent on Newtonsoft.Json >= 6.0.8? Wouldn't it be best to keep the dependencies in this package in line with those of HangFire.Core?

marcoCasamento commented 8 years ago

Yes probably it would. I'm not sure about why it was updated though. Have you tried to use ver 5 ?

zlangner commented 8 years ago

I have not. Though I have gotten it working with 6.0.5 (the version my solution already had) by reverting all the json.net updates that Nuget performs after installing this package. This is quite the hassle if I have to keep doing that every time this package is updated.

Since it seems like there is no reason for this package to have a tighter restriction I'll put together a pull request later today align this with Hangfire.Core, that way any future updates to this package won't cause a Nuget nightmare for anyone unlucky enough to not be on the latest Newtonsoft package.

marcoCasamento commented 7 years ago

I believe that this can now be closed, just lowered and aligned newtonsoft.json to hangfire.core