search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
456 stars 109 forks source link

Allow custom ConnectionMultiplexer instance #24

Closed sjwoodard closed 6 years ago

sjwoodard commented 8 years ago

Resolves #23

marcoCasamento commented 8 years ago

Hi @sjwoodard and thanks for your PR, however the modified constructor loose reference to the supplied RedisStorage. Would you please correct it ?

public RedisStorage(string connectionString, RedisStorageOptions options = null) 
: this(ConnectionMultiplexer.Connect(connectionString)) 
{ 
}
sjwoodard commented 8 years ago

Sorry about that, it should be fixed now

marcoCasamento commented 6 years ago

I believe that this PR should be closed, it has been functionally included in 5c60d20 . Thanks again for the PR, if I'm wrong and it shouldn't be closed, please let me know