search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
456 stars 109 forks source link

Compatibility to NetStandard1_6/DotNetCore #29

Closed Poly3k closed 7 years ago

Poly3k commented 7 years ago

We have a new application which builds upon the new .Net standard framework. Hangfire and Redis are already compatible with that, this adapter is not. With a few changes i made it compatible. Also, the project structure is now ported to the much cleaner xproj version.

marcoCasamento commented 7 years ago

Hi Poly3k thanks for your PR, really valuable. Travis build is not properly configured (shame on me) but appveyor should build. It complains about xunit, do you have any insight ?

Poly3k commented 7 years ago

Hi marcoCasamento, No problem. There is still some room for improvement, i think i will add some commits later this week. (There are two warnings i could get rid off, but it's nothing that breaks the code). I am sadly not experienced with appveyor, but I maybe found some fixes for the tests. FYI: The tests run fine locally.

Do you know if there is a way to test appveyor without the need of committing code?

marcoCasamento commented 7 years ago

Great, merging.

marcoCasamento commented 7 years ago

I believe we should pump the version and align to that of hangfire.core

Poly3k commented 7 years ago

I would agree with that. It will help people. But you are the master, it's your call. Just to be sure (it's my first pull request i made so far). You closed the request but did not merge the branch, is that correct?

marcoCasamento commented 7 years ago

not at all!I didn't want to close it, sorry! Just merged NOW.

About the version, I'll run the code locally in the next few hours, then bump the version and align the nuget package

Poly3k commented 7 years ago

Great! Thanks for your support on this one, I hope it'll help the users!