search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
456 stars 109 forks source link

FetchNextJob performance tweaks. #30

Closed WebApelsin closed 7 years ago

WebApelsin commented 7 years ago

Implemented configurable timeout (instead of hardcoded 3 min) when scanning queues for new jobs. In some cases (e.g. troubles with Redis Pub/Sub) long timeouts can lead to downtime.

Disabled preserving Pub/Sub events order in Redis multiplexer. This could improve Pub/Sub events processing performance.

WebApelsin commented 7 years ago

It seems like there are some troubles with test host configuration in Travis.

marcoCasamento commented 7 years ago

You’re right, your PR builds and tests fine; I’ll take care of issues with Travis.

I’d set FetchTimeout default to 3 minutes, in order to don’t break with the past, do you agree ?

From: WebApelsin [mailto:notifications@github.com] Sent: mercoledì 26 ottobre 2016 08:27 To: marcoCasamento/Hangfire.Redis.StackExchange Hangfire.Redis.StackExchange@noreply.github.com Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] FetchNextJob performance tweaks. (#30)

It seems like there are some troubles with test host configuration in Travis.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marcoCasamento/Hangfire.Redis.StackExchange/pull/30#issuecomment-256260309 , or mute the thread https://github.com/notifications/unsubscribe-auth/AANtY0C9Sn8Mlg5L5NGoh0MFGuxH4Qouks5q3vKvgaJpZM4Kf5tC . https://github.com/notifications/beacon/AANtY0W3ZSB7C3YoFagD3arU3bFyTcG6ks5q3vKvgaJpZM4Kf5tC.gif

WebApelsin commented 7 years ago

Yes, i think it would be rationally. Actually, i've set the default value to 3 minute.

WebApelsin commented 7 years ago

Could you push the new version to Nuget?