Refactor code - Githubissues

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client

Other

452 stars 108 forks source link

Refactor code #64

Closed pieceofsummer closed 6 years ago

pieceofsummer commented 6 years ago

Make GetDashboardMetricFromRedisInfo static (to add dashboard metrics without instantiating RedisStorage)
Remove static Prefix field from RedisStorage (to allow using multiple instances simultaneously)
Add null checks for arguments
Use nameof() instead of hard-coded argument names everywhere
Rule out possible race conditions in RedisMonitoringApi
Suppress deprecation warnings for IServerComponent implementations

marcoCasamento commented 6 years ago

Hi and many thanks for your PR and all of the excellent work!

pieceofsummer commented 6 years ago

I just hope I didn't accidentally break anything :)

pieceofsummer commented 6 years ago

@ryanelian that is a minimum version required. Raising it to 1.6.16 would break compatibility with the older Hangfire versions with no particular reason. For Instance, I’m still using 1.6.0 as a minimum Hangfire version for my Hangfire.Console package.

Since it is a minimum requirement, it doesn’t prevent you from using any newer version of Hangfire in your projects.