limoniapps commented 5 years ago

The library depends on version 1.2.6 of StackExchange.Redis This makes it incompatible with a coebase that is upgraded to StackExchange.Redis v2.

marcoCasamento commented 5 years ago

Right, could you point out any breaking change in the 2.0 ?

marcoCasamento commented 5 years ago

Nevermind, just found this https://stackexchange.github.io/StackExchange.Redis/ReleaseNotes

limoniapps commented 5 years ago

Here are the breaking changes: https://github.com/StackExchange/StackExchange.Redis/blob/master/docs/ReleaseNotes.md

I compiled it against the new version and everything seems to work fine.

From: Marco Casamento notifications@github.com Sent: Wednesday, September 5, 2018 4:49 PM To: marcoCasamento/Hangfire.Redis.StackExchange Hangfire.Redis.StackExchange@noreply.github.com Cc: Bart Coppens bart.coppens@live.com; Author author@noreply.github.com Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)

Right, could you point out any breaking change in the 2.0 ?

From: Bart Coppens notifications@github.com<mailto:notifications@github.com> Sent: mercoledì 5 settembre 2018 15:26 To: marcoCasamento/Hangfire.Redis.StackExchange Hangfire.Redis.StackExchange@noreply.github.com<mailto:Hangfire.Redis.StackExchange@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)

The library depends on version 1.2.6 of StackExchange.Redis This makes it incompatible with a coebase that is upgraded to StackExchange.Redis v2.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marcoCasamento/Hangfire.Redis.StackExchange/issues/77 , or mute the thread https://github.com/notifications/unsubscribe-auth/AANtY5LWHg_EYD6d2O9KPzM80nbQRdiHks5uX9DQgaJpZM4Wa54C . https://github.com/notifications/beacon/AANtY2WvbYBJ7V0yauxyFzbUhnwC_eKuks5uX9DQgaJpZM4Wa54C.gif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/marcoCasamento/Hangfire.Redis.StackExchange/issues/77#issuecomment-418759164, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AO6kIkY45Bixfar0V3YbNnMqV2o4UuhKks5uX-RQgaJpZM4Wa54C.

marcoCasamento commented 5 years ago

and it could be the right time to fix #73 giving that now the only version of stackexchange.redis is strong-named. But we should also upgrade the target framework, so sticking users that can't upgrade to netstandard20 or net461 to the actual version, right ?

limoniapps commented 5 years ago

I agree, although I don’t have much experience with best practices on how to do this for a package like this.

From: Marco Casamento notifications@github.com Sent: Wednesday, September 5, 2018 5:27 PM To: marcoCasamento/Hangfire.Redis.StackExchange Hangfire.Redis.StackExchange@noreply.github.com Cc: Bart Coppens bart.coppens@live.com; Author author@noreply.github.com Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)

and it could be the right time to fix #73https://github.com/marcoCasamento/Hangfire.Redis.StackExchange/issues/73 giving that now the only version of stackexchange.redis is strong-named. But we should also upgrade the target framework, so sticking users that can't upgrade to netstandard20 or net461 to the actual version, right ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/marcoCasamento/Hangfire.Redis.StackExchange/issues/77#issuecomment-418773160, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AO6kIpU7Ka1kvLqKRSVYSbW3pogaiyaAks5uX-1YgaJpZM4Wa54C.