search

marcoCasamento / Hangfire.Redis.StackExchange

HangFire Redis storage based on original (and now unsupported) Hangfire.Redis but using lovely StackExchange.Redis client
Other
452 stars 108 forks source link

Remove Newtonsoft #83

Closed imperugo closed 4 years ago

imperugo commented 5 years ago

Hi, what do you think to remove Newtonsoft from your dependencies and use https://github.com/facebook-csharp-sdk/simple-json instead (it's just a css class that you can copy into your package)?

This could be good in order to prevent conflict with different Newtonsoft dependencies. Does it make sense to you? PR?

marcoCasamento commented 4 years ago

Sorry I've dedicated very little to nothing to this project. It's a great idea, I didn't even know of this project and yet newtonsoft has often bugged me and I usually go with assembly binding... where possible. thanks for the input. I can try to do the change myself but if you're still willing to make a PR it's more than welcome

neyromant commented 4 years ago

@marcoCasamento seems like Newtontonsoft.Json was added to deps but didn't use. I made PR for remove it https://github.com/marcoCasamento/Hangfire.Redis.StackExchange/pull/93