marcoXbresciani / TKCompanionApp

A short and small helper for Toyota Kata practitioners - If you're reading this here on GitHub, please note that main repository is now Codeberg: https://codeberg.org/marco.bresciani/TKCompanionApp
GNU General Public License v3.0
3 stars 1 forks source link

Remove useless permission #2

Closed licaon-kter closed 2 years ago

licaon-kter commented 2 years ago

Ref: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10384#note_815532338 and #3

Ref: https://stackoverflow.com/questions/49962542/why-google-play-services-dependency-automatically-added-com-google-android-finsk

Ref: https://github.com/magus/react-native-facebook-login/issues/233#issuecomment-343938375

marcoXbresciani commented 2 years ago

Thank you @licaon-kter! Does this mean to basically get out from the managed workflow? I mean, the whole android folder is automagically created by Expo, not by me. Is it proper to manually modify it? So I have to manually update the AndroidManifest.xml file everytime I create the build. 😢

licaon-kter commented 2 years ago

Oh, you're that dev ? :)

Uhh, yeah...kinda you do then :) :(

Or find a better way by controlling Expo?

marcoXbresciani commented 2 years ago

Please be kind: I'm an old Java guy. After 20+ years of that, I've started learning the app world alone, from scratch, and I thought React Native was nice, but then I've found that Expo might help simplifying some things... So I've thought to give it a try. Maybe React Native alone would have been better! :)

licaon-kter commented 2 years ago

Should have stayed with Java :))