search

marcocesarato / php-conventional-changelog

A PHP tool built to generate a changelog from a project's commit messages and metadata following the conventionalcommits.org and automate versioning with semver.org.
GNU General Public License v3.0
230 stars 32 forks source link

Composer update when releasing a new version #13

Closed shaffe-fr closed 3 years ago

shaffe-fr commented 3 years ago

Hi @marcocesarato, Since commit ea8fb7eded13e6924388f044044a9898ec810163, composer update is run automatically when releasing a new version. Updating the dependecies is not always trivial, it can lead to unexpected bugs and I think that its outside this package boundaries. May I ask you why you decided to run composer update when creating releases?

Thanks

marcocesarato commented 3 years ago

Hi, it's related the this implementation #11 so to update the version key on composer.lock I'll add soon an option on config to avoid to update the project dependencies.

shaffe-fr commented 3 years ago

Hi, I can't find my project version number in my composer.lock. In what node should it be stored?

marcocesarato commented 3 years ago

I've not found it some of my project but the guy who proposed the features said

Also, add the version key to composer.lock

And to be sure of that I inserted a composer update but in fact I don't find it. Probably is better remove it

shaffe-fr commented 3 years ago

Thanks for the quick fix!