search

marcocesarato / php-conventional-changelog

A PHP tool built to generate a changelog from a project's commit messages and metadata following the conventionalcommits.org and automate versioning with semver.org.
GNU General Public License v3.0
227 stars 32 forks source link

fix!: sort git tags by version instead of creation date, match prefix… #33

Closed juckerf closed 2 years ago

juckerf commented 2 years ago

… when listing tags

git tags were sorted by creation date which can lead to wrong versions. Consider a scenarion where a patch version (e.g. 1.0.1) for an older version (e.g. 1.0.0) is released after a major version has been released (e.g. 2.0.0). With the current sorting any new tag is created based on 1.0.1, even if it's code is based on 2.0.0. To further clarify/stabilize the determination of the latest tag, the configured tag prefix (if any) is taken into account when listing tags.

BREAKING CHANGE: Workflows which rely on the chronological order of tags will potentially break. Also workflows with mixed tag prefixes will potentially break.

juckerf commented 2 years ago

@marcocesarato the check Conventional PR fails due to some issues with the action itself (see https://github.com/marcocesarato/php-conventional-changelog/runs/4456521647?check_suite_focus=true) Do you consider a merge of this PR despite the failing check?

Let me know if there's anything I can adapt on my PR (regarding the failing check or also regarding the content of my PR)