search

marcocesarato / react-native-big-list

This is a high performance list view for React Native with support for complex layouts using a similar FlatList usage to make easy the replacement. This list implementation for big list rendering on React Native works with a recycler focused on performance and memory usage and so it permits processing thousands items on the list.
https://marcocesarato.github.io/react-native-big-list-docs/
Apache License 2.0
525 stars 41 forks source link

fix: allow overwriting elevation in style of section header #270

Closed larsmunkholm closed 1 year ago

larsmunkholm commented 1 year ago

Not sure if this is a fix or a feature, but I don't think the change is big enough to be a feature.

I am experiencing some inconsistencies in the look of my section headers due to the elevation style property.

This PR allows developers to overwrite elevation without changing the look and functionality of the list for everybody who is happy with how the headers function today.

Screenshot 2022-10-22 at 18 35 09 Screenshot 2022-10-22 at 18 36 14

(Both screenshots show how the headers look on different Android devices with elevation set to 10)

larsmunkholm commented 1 year ago

I am aware of the bug report that led to the implementation of the elevation style, however, I don't experience this problem with elevation set to 0. I believe this PR will solve the problem for all of us :)