search

marcocorvi / topodroid

TopoDroid code base
https://sites.google.com/site/speleoapps/
GNU General Public License v3.0
54 stars 26 forks source link

"More shot edit" window has no "Ok" button #100

Closed rsevero closed 7 months ago

rsevero commented 8 months ago

Describe the bug "More shot edit" window has no "Ok" button

To Reproduce Steps to reproduce the behavior:

  1. Go to shot edit dialog box for a splay.
  2. Click on "More" to open the "More shot edit" window
  3. Enter LRUD data or change the splay color.
  4. See that there is no "Ok" or "Save" button to close and save the changes.

Expected behavior There should be a "Ok" or "Save" button on the "More shot edit" window so the user can save any changes.

Device (please complete the following information):

marcocorvi commented 8 months ago

lrud are at an intermediate point, for old-style cave models. therefore, they should not be there for splay shots.

all buttons are actions after which the dialog is closed (in practice the dialog may even close before the action is performed). when the action is done the control returns to the data list window.

On Thu, Apr 4, 2024, 4:53 PM Rodrigo Severo @.***> wrote:

Describe the bug "More shot edit" window has no "Ok" button

To Reproduce Steps to reproduce the behavior:

  1. Go to shot edit dialog box for a splay.
  2. Click on "More" to open the "More shot edit" window
  3. Enter LRUD data or change the splay color.
  4. See that there is no "Ok" or "Save" button to close and save the changes.

Expected behavior There should be a "Ok" or "Save" button on the "More shot edit" window so the user can save any changes.

Device (please complete the following information):

  • Samsung Galaxy 23 FE
  • Android 14
  • TopoDroid 6.2.60-34

— Reply to this email directly, view it on GitHub https://github.com/marcocorvi/topodroid/issues/100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMYCYRKNGYFEEHSEPNQ33Y3VSP3AVCNFSM6AAAAABFXOGK56VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDKNZTHA3TSMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rsevero commented 8 months ago

lrud are at an intermediate point, for old-style cave models. therefore, they should not be there for splay shots. all buttons are actions after which the dialog is closed (in practice the dialog may even close before the action is performed). when the action is done the control returns to the data list window.

Not for the color setting.

marcocorvi commented 8 months ago

it is just that the color is not imnediately shown in the list. this is stated in the help page

On Thu, Apr 4, 2024, 9:00 PM Rodrigo Severo @.***> wrote:

lrud are at an intermediate point, for old-style cave models. therefore, they should not be there for splay shots. all buttons are actions after which the dialog is closed (in practice the dialog may even close before the action is performed). when the action is done the control returns to the data list window.

Not for the color setting.

— Reply to this email directly, view it on GitHub https://github.com/marcocorvi/topodroid/issues/100#issuecomment-2037989714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMYC5D7RBPG3GEYFUSAE3Y3WPNJAVCNFSM6AAAAABFXOGK56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXHE4DSNZRGQ . You are receiving this because you commented.Message ID: @.***>

rsevero commented 8 months ago

it is just that the color is not imnediately shown in the list. this is stated in the help page

When I set the splay color using the color option in the "More shot edit" dialog, after setting the color in the color palete, I am returned to the "More shot edit" dialog box. The color is already set but I only have the "Cancel" button to close the window.

As you said, the color is not immediatly shown. It gets really confusing for the user. I supposely set the color but I clicked in a "Cancel" button and the color in not shown. Is the color really set or not?

I see that it is but it is really confusing. Maybe if the whole dialog box was closed when I choose the color in the color palete it woudl get less confusing.

And, even better, if the new color is shown at this moment in the splay, then it would be perfect.

marcocorvi commented 8 months ago

i agree with you: the color immediately shown is the best.

i did not do it, because i was counting the number of taps to set color. with the dialog it is 3: open the edit dialog, the more dialog, the color. with multishot it is 3: go multishot, tap the light button, then the color.

i'm not sure that having the color in the more dialog is any better that using the multishot

On Thu, Apr 4, 2024, 9:20 PM Rodrigo Severo @.***> wrote:

it is just that the color is not imnediately shown in the list. this is stated in the help page

When I set the splay color using the color option in the "More shot edit" dialog, after setting the color in the color palete, I am returned to the "More shot edit" dialog box. The color is already set but I only have the "Cancel" button to close the window.

As you said, the color is not immediatly shown. It gets really confusing for the user. I supposely set the color but I clicked in a "Cancel" button and the color in not shown. Is the color really set or not?

I see that it is but it is really confusing. Maybe if the whole dialog box was closed when I choose the color in the color palete it woudl get less confusing.

And, even better, if the new color is shown at this moment in the splay, then it would be perfect.

— Reply to this email directly, view it on GitHub https://github.com/marcocorvi/topodroid/issues/100#issuecomment-2038037314, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMYC5Q3EJ74PYITSCJKLDY3WRWHAVCNFSM6AAAAABFXOGK56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGAZTOMZRGQ . You are receiving this because you commented.Message ID: @.***>

rsevero commented 8 months ago

i agree with you: the color immediately shown is the best. i did not do it, because i was counting the number of taps to set color. with the dialog it is 3: open the edit dialog, the more dialog, the color. with multishot it is 3: go multishot, tap the light button, then the color. i'm not sure that having the color in the more dialog is any better that using the multishot

I agree that using the multishot color editing is better but not having it at the shot editor is confusing. I really believe it should be there also.

But if you prefer to remove it, I can leave without it. Newbies might have a harder time.

marcocorvi commented 8 months ago

newbies don't go to the more dialog.

one big problem of topodroid is how to make the interface simpler. adding more stuff inevitably makes the interface more complex.

the more dialog is a catch for all those wierd seldom used actions, that would make the edit dialog unnecessary cluttered.

as a matter of fact "more" should be "more/less" and open/close the box with extra actions. i never liked having two dialogs. at first it was necessary because of screen estate, and scrolling in a dialog is not nice, but now phones are becoming taller.

On Thu, Apr 4, 2024, 9:31 PM Rodrigo Severo @.***> wrote:

i agree with you: the color immediately shown is the best. i did not do it, because i was counting the number of taps to set color. with the dialog it is 3: open the edit dialog, the more dialog, the color. with multishot it is 3: go multishot, tap the light button, then the color. i'm not sure that having the color in the more dialog is any better that using the multishot

I agree that using the multishot color editing is better but not having it at the shot editor is confusing. I really believe it should be there also.

But if you prefer to remove it, I can leave without it. Newbies might have a harder time.

— Reply to this email directly, view it on GitHub https://github.com/marcocorvi/topodroid/issues/100#issuecomment-2038056360, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMYCYNSVPSB4AZOJ7ATALY3WTA7AVCNFSM6AAAAABFXOGK56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGA2TMMZWGA . You are receiving this because you commented.Message ID: @.***>

rsevero commented 8 months ago

newbies don't go to the more dialog. one big problem of topodroid is how to make the interface simpler. adding more stuff inevitably makes the interface more complex. the more dialog is a catch for all those wierd seldom used actions, that would make the edit dialog unnecessary cluttered. as a matter of fact "more" should be "more/less" and open/close the box with extra actions. i never liked having two dialogs. at first it was necessary because of screen estate, and scrolling in a dialog is not nice, but now phones are becoming taller.

I like this idea.

marcocorvi commented 7 months ago

Shot edit-more dialog has been included in shot edit dialog