Chrome version checking for body class is broken when version number is longer than 2 digits.

[GoogleCodeExporter]

dynamic-classes.php line 335 
The regular expression you use to match chrome and other browsers is only set 
to find \d.\d when it should be \d+.\d+  which would account for version 
numbers like 11.18

Original issue reported on code.google.com by tin...@gmail.com on 28 Apr 2011 at 3:55

[GoogleCodeExporter]

Thanks for your report. Will check this in the next 1 or 2 hours.

Original comment by chris.gossmann@googlemail.com on 28 Apr 2011 at 6:35

[GoogleCodeExporter]

Ok .. tested.

Will check for the other browsers over the weekend. A last question: do we need 
the exact version numbers? Will CSS bugs adressed in minor browser updates?

Sorry, but I'm on vacation with limited internet access.

Original comment by chris.gossmann@googlemail.com on 28 Apr 2011 at 9:21

• Changed state: Started

[GoogleCodeExporter]

I saw this issue as well while using Chrome on Ubuntu. This is the patch that I 
came up with to fix the issue. 
- Wrapping each of the preg_match functions in 'if' statements so that if the 
format that is expected is not found then the version information is skipped, 
instead of outputting notices of undefined indexes (if your wp debug is on).
- Added \d+ instead of \d to the digits.

Original comment by lea...@gmail.com on 24 Jun 2011 at 4:35

Attachments:

• dynamic-classes-0.diff

[GoogleCodeExporter]

Fixed with r773

Original comment by chris.gossmann@googlemail.com on 1 Sep 2011 at 2:19

• Changed state: Fixed