Deprecation of part of thematic_widgets_init

[GoogleCodeExporter]

I'm thinking that the code credited to Joern Kretzschmar in 
thematic_widgets_init() is dead weight and should be removed to a deprecated 
function to alert potential users of this method of file inclusion to use a 
recommended method.

Here's my problem with it:

We are searching for files in a directory that was never added to the parent 
theme for the purpose of including widgets.  Why are we searching for something 
we know is not there? This would seem to be core WP territory to me.

The child theme bit is sticky. I guess someone could be using this code but IMO 
they should be including or requiring files from their functions.php

See patches. If there are no objections I'll move on and commit.

Original issue reported on code.google.com by eugene.m...@gmail.com on 22 Jan 2012 at 6:49

Attachments:

• widgets-ext-less.diff
• deprecated-addition.diff

[GoogleCodeExporter]

Original comment by eugene.m...@gmail.com on 23 Jan 2012 at 1:06

• Added labels: Deprecation

[GoogleCodeExporter]

Hi Gene,

go for it. I added this code before the Widget API change. As far as I can 
remember, the code doesn't work any longer since the API change. Just forgot to 
remove it :)

Chris

Original comment by chris.gossmann@googlemail.com on 23 Jan 2012 at 9:38

[GoogleCodeExporter]

go for it, agree that it is silly to look for something that isn't there in 
thematic.  i never even knew it was there until i worked on the other ticket 
since it didn't work if someone had changed wp-content to some custom folder.  

Original comment by helgathe...@gmail.com on 23 Jan 2012 at 8:43

[GoogleCodeExporter]

OK I just removed the whole thing. Deprecating the function would create 
arbitrary notices based on a choice of directory naming schema. That doesn't 
seem right. I doubt anyone but us even realizes this code was ever here.

Original comment by eugene.m...@gmail.com on 24 Jan 2012 at 1:35

• Changed state: Fixed