WordPress 3.4 wp_title() adjustments

[GoogleCodeExporter]

3.4 requires that you filter wp_title() instead of directly editing the 
document title.  karin fixed this in our fork, so here is the patch.  i'm not 
sure if we have to deprecate or backcompat anything for this. 

Original issue reported on code.google.com by helgathe...@gmail.com on 13 Jun 2012 at 11:19

Attachments:

• header-extensions.php.patch

[GoogleCodeExporter]

working on theme review compat now thanks :)

Original comment by eugene.m...@gmail.com on 14 Jun 2012 at 8:18

• Added labels: Theme-Review

[GoogleCodeExporter]

r854 

I think its better not to change the titles that are generated.

I was wondering about the priority of 2 on the forks filter of wp_title why not 
the recommended 3?

Original comment by eugene.m...@gmail.com on 16 Jun 2012 at 2:09

[GoogleCodeExporter]

To be honest I didn't do much work on that one but lifted it straight from 
Chip's Oenology theme. The prio is the same, 10. The 2 refers to the number of 
arguments - Chip didn't use the third $seplocation one. I guess this is because 
since he puts 'right' as parameter to the wp_title function, he knows where it 
is and there is no need for it in the filter. I noticed that thematic_wptitle() 
only accepts 1 argument even though the call to the wp_title filter says 3.

function thematic_wptitle( $wp_doctitle ) 

vs

function thematic_wptitle( $wp_doctitle, $sep, $sep_location )

Since the separator is passed in the filter we don't need to apply the filter 
thematic_doctitle_separator twice. 

I agree on not changing the generation of the titles, I was just taking a 
shortcut.

Original comment by invistr...@gmail.com on 16 Jun 2012 at 12:32

Attachments:

• -149-wptitle.diff

[GoogleCodeExporter]

did this get added yet?  can we close the issue?

Original comment by helgathe...@gmail.com on 27 Jun 2012 at 9:00

[GoogleCodeExporter]

Original comment by eugene.m...@gmail.com on 29 Oct 2012 at 12:14

• Changed state: Fixed