Full Page Template CSS Issue

[GoogleCodeExporter]

What steps will reproduce the problem?
1. enable a Full Width page template with any of the layouts

What is the expected output? What do you see instead?

the #content div doesn't always line up properly depending on the layout (since 
it floats differently depending on the chosen layout) and the right edge is 
actually 10px short.  Since #container is set for the template to width: 940px, 
then #content is also set to #940px, w/ a 10px left margin... and but since the 
overflow is hidden, this means that technically the #content div is limited to 
930px (or the last 10px are hidden).  

a possible solution is that #container be set to width: 100% and #content get a 
margin: 0 auto

What version of the product are you using? On what operating system?
Thematic 0.9.7.5, Windows 7

Original issue reported on code.google.com by helgathe...@gmail.com on 5 Oct 2010 at 8:50

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Patch queen... Have you got something for us on this one?

Original comment by eugene.m...@gmail.com on 17 Jan 2012 at 9:08

[GoogleCodeExporter]

implemented my above suggestion

Original comment by helgathe...@gmail.com on 17 Jan 2012 at 9:35

Attachments:

• 2c-l-fixed.css
• 2c-r-fixed.css
• 3c-fixed.css
• 3c-r-fixed.css
• 3c-r-fixed-primary.css

[GoogleCodeExporter]

One thing off the cuff... Will that body class persist when childtheme's switch 
between thematic function and the default wp body_class function?

Original comment by eugene.m...@gmail.com on 17 Jan 2012 at 9:41

[GoogleCodeExporter]

turned off thematic classes in my child theme and the class persists.   
template appears to be part of wp's body class.  

Original comment by helgathe...@gmail.com on 17 Jan 2012 at 9:50

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

OK, Ive been avoiding this one for too long now. I agree that this template has 
presented style issues. I'm wondering if any custom page templates should have 
been added to Thematic in the first place. 

I'm having a hard time with adding the styes to every layout stylesheet to 
solve this. It's like the tail is wagging the dog here.

Lets pause on this and reconsider our end-point. Once we decide where we're 
going with Thematic, I think we'll be better equipped to make changes that 
stick around.

 This would be a heckuva lot easier if we used body class based layouts. Unfortunately Thematic wasn't originally designed to use a class cascading layout. It @imports the layouts generating a mess of http requests.  I'd like to see thematic move to a class based layout system; but the last time I brought it up Ian wasn't keen on the idea. 

Maybe it's time to reconsider that as a feature in a 1.0 and deprecate the old 
stylesheets. 

Original comment by eugene.m...@gmail.com on 7 Feb 2012 at 8:17

[GoogleCodeExporter]

I've been working a lot lately with Thematic and it would be a bad idea to 
support multiple page templates. The full width one has already caused a lot of 
problems for people..even though I have fixed it, albeit not in a permanent 
way. Would be better to use more templates when/if Thematic 5 is released 
(HTML5 version of Thematic).

Original comment by Jagst3...@gmail.com on 19 Mar 2012 at 4:18

[GoogleCodeExporter]

what if we combined all the stylesheets and the layout was decided by body 
class?  there are only a few items that are different anyway (#primary, 
#secondary, #content and #container come to mind).  that'd also be easy to hook 
up to a theme option and/or a metabox for individual page level style changes.  
(i think i've done both with child themes already)

Original comment by helgathe...@gmail.com on 19 Mar 2012 at 12:07

[GoogleCodeExporter]

sounds like a good idea, but at this rate adding more stuff will delay Thematic 
even more, won't it? I say a 1.0 should just be released and we move on to 
Thematic 5 :)

Original comment by Jagst3...@gmail.com on 24 Mar 2012 at 1:47

[GoogleCodeExporter]

Trying to clear the static on this board since development has now moved to 
gtihub.

If anyone sees fit to address this discussion again please do so at 
https://github.com/ThematicTheme/Thematic/issues

Thank you!

Original comment by eugene.m...@gmail.com on 28 Oct 2012 at 9:53

• Changed state: WontFix