MattCrich
commented
6 years ago Hi, the problem should be fixed now.
Closed valerio-castelli closed 6 years ago
MattCrich
commented
6 years ago Hi, the problem should be fixed now.
ingconti
commented
6 years ago You have warnings now:
[WARNING] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/GUI.java: Some input files use or override a deprecated API. [WARNING] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/GUI.java: Recompile with -Xlint:deprecation for details. [WARNING] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Server/Game/ServerRete/Game.java: Some input files use unchecked or unsafe operations. [WARNING] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Server/Game/ServerRete/Game.java: Recompile with -Xlint:unchecked for details.
marcodigia
commented
6 years ago Hi, GUI warning should be fixed now.
valerio-castelli
commented
6 years ago You still have the same issue on Game.java; in addition, we can't see your tests because your pom.xml is still incorrect. Please follow this guide thoroughly until the end and be sure to add all the necessary dependencies, as well as the surefire plugin (with its nested dependencies). Please fix this ASAP.
marcodigia
commented
6 years ago pom.xml should be fixed now, we followed the guide
valerio-castelli
commented
6 years ago I can confirm the issue has been solved. However, you still have a minor fix to do to the pom.xml: [WARNING] Some problems were encountered while building the effective model for it.polimi.ingsw:LM48:jar:1.0-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 10, column 21
valerio-castelli
commented
6 years ago Fixed, closing issue.
valerio-castelli
commented
6 years ago New issue:
[ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/GUI.java:[15,8] it.polimi.ingsw.Client.GUI.GUI is not abstract and does not override abstract method askForAnotherDice() in it.polimi.ingsw.UI [ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/ControllerConnection.java:[17,8] it.polimi.ingsw.Client.GUI.ControllerConnection is not abstract and does not override abstract method askForAnotherDice() in it.polimi.ingsw.UI [ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/ControllerLogin.java:[31,8] it.polimi.ingsw.Client.GUI.ControllerLogin is not abstract and does not override abstract method askForAnotherDice() in it.polimi.ingsw.UI [ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/ControllerChooseWindowPattern.java:[29,8] it.polimi.ingsw.Client.GUI.ControllerChooseWindowPattern is not abstract and does not override abstract method askForAnotherDice() in it.polimi.ingsw.UI [ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Client/GUI/ControllerLobby.java:[21,8] it.polimi.ingsw.Client.GUI.ControllerLobby is not abstract and does not override abstract method askForAnotherDice() in it.polimi.ingsw.UI
marcodigia
commented
6 years ago Hi, this issue should be fixed
valerio-castelli
commented
6 years ago Confirmed, I'm closing the issue.
Buongiorno, vi segnalo che, al momento in cui scrivo, il vostro codice risulta non compilabile da Jenkins. Avete probabilmente pushato codice non compilabile. L'errore riscontrato è il seguente: [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /var/jenkins_home/workspace/LM48/src/main/java/it/polimi/ingsw/Server/Game/GameRules/Actions/Basic/UseToolCardBasic.java:[34,62] method getActions in class it.polimi.ingsw.Server.Game.Cards.ToolCard cannot be applied to given types; Siete invitati a correggere il problema il più rapidamente possibile; vi ricordo inoltre che il codice pushato sul branch master deve sempre essere compilabile.