search

marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
493 stars 28 forks source link

Gradle Config DSL #14

Closed marcoferrer closed 4 years ago

marcoferrer commented 5 years ago

This PR is for issue #8

This change is Reviewable

codecov-io commented 4 years ago

Codecov Report

Merging #14 into master will increase coverage by 1.24%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #14      +/-   ##
============================================
+ Coverage     85.29%   86.53%   +1.24%     
  Complexity       19       19              
============================================
  Files            15       15              
  Lines           306      312       +6     
  Branches         49       53       +4     
============================================
+ Hits            261      270       +9     
+ Misses           16       15       -1     
+ Partials         29       27       -2
Impacted Files Coverage Δ Complexity Δ
.../marcoferrer/krotoplus/coroutines/call/CallExts.kt 84.84% <0%> (-3.04%) 0% <0%> (ø)
...oferrer/krotoplus/coroutines/client/ClientCalls.kt 87.17% <0%> (ø) 0% <0%> (ø) :arrow_down:
...utines/call/FlowControlledInboundStreamObserver.kt 82.6% <0%> (+3.44%) 0% <0%> (ø) :arrow_down:
...rcoferrer/krotoplus/coroutines/call/FlowControl.kt 89.18% <0%> (+5.85%) 0% <0%> (ø) :arrow_down:
...s/coroutines/client/ClientResponseStreamChannel.kt 100% <0%> (+14.28%) 9% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f42efb...c611f26. Read the comment docs.

marcoferrer commented 4 years ago

I still need to fix the repository configuration in the example project. @mattdkerr Let me know what your impressions are about the kroto config dsl and it’s usage. The example project build file shows how to create a config and apply it to protobuf Gradle. This was the last thing I wanted to get into the 0.6.0 release