search

marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
493 stars 28 forks source link

Coroutine scope stub builder ext #43

Closed marcoferrer closed 5 years ago

marcoferrer commented 5 years ago

Stubs implementing CoroutineScope have proven to cause issues with ambiguous scope resolution. To reduce error prone client code, we are removing CoroutineScope as a super interface from generated stubs. In addition, a new ext to CoroutineScope has been added called newGrpcStub. This is meant to represent the clear intent of launching children within the stub using the context of receiving scope.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@3f970a8). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #43   +/-   ##
==========================================
  Coverage           ?   89.09%           
  Complexity         ?       19           
==========================================
  Files              ?       15           
  Lines              ?      266           
  Branches           ?       37           
==========================================
  Hits               ?      237           
  Misses             ?       10           
  Partials           ?       19
Impacted Files Coverage Δ Complexity Δ
...ub/marcoferrer/krotoplus/coroutines/StubSupport.kt 100% <100%> (ø) 0 <0> (?)
...errer/krotoplus/coroutines/CoroutineCallOptions.kt 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f970a8...2827b83. Read the comment docs.