search

marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
494 stars 28 forks source link

Add support for malformed protobuf filenames #56

Closed marcoferrer closed 5 years ago

marcoferrer commented 5 years ago

Not all existing protobuf files follow the convention of snake case for file names. We should ensure that we support any non erroneous format supported by the java and grpc protoc plugins.

marcoferrer commented 5 years ago

CC: @AlexeySoshin

AlexeySoshin commented 5 years ago

Do you want to take it, or should I?

marcoferrer commented 5 years ago

You’re more than welcome to pick it up. Thanks again for bringing it to my attention. We will need to verify what’s is considered valid by protoc-gen-java and match that.

Test proto files can be added to the test-api module. They can then have simple assertions added in the generator-tests module. Nothing fancy is needed since compilation will verify if the out is correct. That module will contain existing examples.

If you run into any issues of have any questions feel free to reach out