search

marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
493 stars 28 forks source link

Fallback to codegen request when file filter is missing #70

Closed marcoferrer closed 5 years ago

marcoferrer commented 5 years ago

At the moment Kroto is ignoring what files are being requested for generation by protoc. The file filtering is purely based on whatever configuration is provided by users.

In order to keep backwards compatibility, kroto should honor existing file filters. But in the event that a file filter is not defined we should fall back to checking the original list of files to generate in the codegen request.

codecov-io commented 5 years ago

Codecov Report

Merging #70 into master will increase coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     85.76%   86.09%   +0.33%     
  Complexity       19       19              
============================================
  Files            15       15              
  Lines           302      302              
  Branches         48       48              
============================================
+ Hits            259      260       +1     
  Misses           15       15              
+ Partials         28       27       -1
Impacted Files Coverage Δ Complexity Δ
...otoplus/coroutines/client/ClientBidiCallChannel.kt 100% <0%> (+4.34%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d5aba2...0cda1d3. Read the comment docs.