Closed kasingal closed 4 years ago
Sorry about the delayed response. Im sorry but yes there are currently issues when using the plugin within windows environments. It is discussed extensively in https://github.com/marcoferrer/kroto-plus/issues/6
The quickest short term workaround is outlined in this comment https://github.com/marcoferrer/kroto-plus/issues/6#issuecomment-505099688
There is a long term stable solution currently queued up for the next release is this PR https://github.com/marcoferrer/kroto-plus/pull/87
Thanks @marcoferrer-- I left a single comment on the PR. Otherwise it looks good to me.
@mattdkerr No worries. ~Thanks again for reporting.~ The PRs been merged and I published a snapshot of 0.6.0
Please let me know if you run into anymore issues. I’m really happy to get this resolved. The issues with windows compatibility have been bugging me for a while.
I pulled in the 0.6.0-SNAPSHOT
version and changed the line to look like:
artifact = "com.github.marcoferrer.krotoplus:protoc-gen-kroto-plus:$krotoPlusVersion"
and then I get successful generateProto
and compileJava
sequences. Thanks!
Will this then be released?
Awesome thanks for the confirmation! The goal is to release later this week.
Using 0.6.0-SNAPSHOT
and removing :jvm8@jar
from the artifact in my protobuf config got this working on Windows for me.
My full protobuf config is:
protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protobuf_version"
}
//noinspection GroovyAssignabilityCheck
plugins {
grpc { artifact = "io.grpc:protoc-gen-grpc-java:$grpc_version" }
coroutines {
artifact = "com.github.marcoferrer.krotoplus:protoc-gen-grpc-coroutines:$krotoplus_version"
}
}
generateProtoTasks {
all().each{ task ->
task.plugins {
grpc {}
coroutines {}
}
}
}
}
With 0.6.0
released, there is now an executable windows artifact available.
It works on Ubuntu, MacOS but fails on Windows 10. Using below execution configutration (with kroto-plus.version = 0.5.0)
Windows Info:
Failed Error Logs: