search

marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
494 stars 28 forks source link

pb-and-k support #89

Closed Globegitter closed 4 years ago

Globegitter commented 4 years ago

It would be nice to be able to fully utilise kotlin features, also for the protobuf creation itself. What do you think of supporting https://github.com/cretz/pb-and-k - would this be something feasible/useful?

marcoferrer commented 4 years ago

I have no opposition to supporting pb-and-k. I was actually very interested in it. Originally I was working on a poc to support it but the author mentioned here that he didnt have capacity anymore to support pb-and-k.

The other full kotlin protobuf alternative is kotlinx serialization. I had placed a hold on integration with that project since it was still lacking support for some proto3 features like oneof at the time.

Globegitter commented 4 years ago

Thanks for the quick response, there is also wire, but it also has only limited proto3 support. Is the issue you are referring to: https://github.com/Kotlin/kotlinx.serialization/issues/67?

But either way the reasoning makes total sense for not supporting pb-and-k, so the issue can be closed.

Hopefully some of the other options will progress over the coming months.

Globegitter commented 4 years ago

@marcoferrer Turns out an organisation has forked pb-and-k and is now maintaining it: https://github.com/streem/pbandk could be worth taking a look at. What do you think?

RdeWilde commented 3 years ago

Also kotlinx serialization has progressed. We should be good to go. Where to start?