marcoferrer / kroto-plus

gRPC Kotlin Coroutines, Protobuf DSL, Scripting for Protoc
Apache License 2.0
494 stars 28 forks source link

Update method signature support to adhere to spec #92

Closed marcoferrer closed 4 years ago

marcoferrer commented 4 years ago

The current implementation of support for method signature options is compliant with the specification defined in googleapis/api-common-protos/client.proto#L79

The following changes need to be made to become spec compliant.

The current implementation incorrectly assumes that there is only ever one target method signature to implement. It also collects all of the signature annotation entries on a method and treats them as the fields to output in the target signature.