search

marcofiset / Testify.php

A micro unit testing framework
http://marco-fiset.github.com/Testify.php/
129 stars 27 forks source link

System rewrite #4

Closed xeoncross closed 11 years ago

xeoncross commented 12 years ago

Cleaner test and assertion names for better test summaries. Addd CLI report. Smaller file size. Basically, it's almost a full rewrite to improve everything. Also, it's now closer to the PSR-0 Standard with a capital file name.

marcofiset commented 11 years ago

Hi,

I just inherited the ownership of the project from Martin as he lost interest in it. I am in the process of evaluating the current pull requests to merge them into the main code base. However, I don't feel like you rewrite adds any value to the project. I don't like how you rely on a magic method to define assertions.

Plus in your example, there is a lot of information duplication like when testing for equality:

$tf->isEqual(1 == 1);

I feel there is something wrong with a test called ìsEqual` and passing a boolean condition that tests for equality. Your intent seems to be for better tests summaries. I already implemented something similar. Now you can pass a string in the assertion method and what you pass in will be displayed as the test summary instead of the assertion method you called.

Please tell me what you think about it! I know it's been a long time since you wrote this code and maybe you just don't want it to be merged anymore. I'll wait to hear from you.

Regards, Marco