search

marcofugaro / three-projected-material

📽 Three.js Material which lets you do Texture Projection on a 3d Model
https://marcofugaro.github.io/three-projected-material/
MIT License
674 stars 58 forks source link

Constant LogLuvEncoding removed in three r135 #30

Closed remmel closed 2 years ago

remmel commented 2 years ago

Hello,

The constant export const LogLuvEncoding = 3003; has been removed in three r135 : https://github.com/mrdoob/three.js/commit/1d544d0fd254775c36e222e088833a3d4b3c2220

To avoid that warning 

WARNING in ./node_modules/three-projected-material/build/ProjectedMaterial.module.js 79:9-29
"export 'LogLuvEncoding' (imported as 'THREE') was not found in 'three'

The case might be removed from https://github.com/marcofugaro/three-projected-material/blob/5e0ed6d0be30db43850384fb09acb7400a2d718f/src/three-utils.js#L62

Thanks!

marcofugaro commented 2 years ago

AH DAMN, thanks you for the heads up!

remmel commented 2 years ago

in r137 GammaEncoding, LogLuvEncoding, RGBDEncoding, RGBEEncoding, RGBM16Encoding, RGBM7Encoding has been also removed https://github.com/mrdoob/three.js/commits/r137/src/constants.js

https://github.com/mrdoob/three.js/commits/master/src/constants.js

marcofugaro commented 2 years ago

Fixed in v2.1.0!