marcojak / MauiMTAdmob

MIT License
115 stars 18 forks source link

include dotnet8.0 in TargetFrameworks #108

Open Th3L0x opened 1 week ago

Th3L0x commented 1 week ago

Could you include dotnet8.0? Because if somebody wants use xUnitTest while this package is installed the package restore will fail. (only android, ios, maccatalyst and windows are included)

marcojak commented 1 week ago

.net8 is already included in all platforms. Make sure everything is updated and it will work.

On Sun, 10 Nov 2024, 21:42 Th3L0x, @.***> wrote:

Could you include dotnet8.0? Because if somebody wants use xUnitTest while this package is installed the package restore will fail. (only android, ios, maccatalyst and windows are included)

— Reply to this email directly, view it on GitHub https://github.com/marcojak/MauiMTAdmob/issues/108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUIPIXPXOMDY5VJRD2525LZ77HLHAVCNFSM6AAAAABRQTQNC6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2DONRYGU3TQMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Th3L0x commented 1 week ago

2 3 1

I mean pure dotnet8.0, unfortunately this is a must for xUnit Test type project

marcojak commented 1 week ago

Oh I see. I'll add it and do some tests and if all works fine, I'll release it asap.

On Sun, 10 Nov 2024, 21:53 Th3L0x, @.***> wrote:

2.PNG (view on web) https://github.com/user-attachments/assets/65872bd6-45d4-4af6-8f60-61f54fe79eeb 3.PNG (view on web) https://github.com/user-attachments/assets/bed8c765-531f-46a8-8a19-80992c568086 1.PNG (view on web) https://github.com/user-attachments/assets/732604a8-79c8-4b3f-b399-12b1d82287ec

I mean pure dotnet8.0, unfortunately this is a must for xUnit Test type project

— Reply to this email directly, view it on GitHub https://github.com/marcojak/MauiMTAdmob/issues/108#issuecomment-2466949860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUIPISW72U2Z5NOUFIUXWDZ77IVXAVCNFSM6AAAAABRQTQNC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWHE2DSOBWGA . You are receiving this because you commented.Message ID: @.***>

Th3L0x commented 1 week ago

Thank you!

Th3L0x commented 6 hours ago

Hey, do you have any news on this?:)