search

marcojakob / dart-dnd

Drag and Drop for Dart web apps with mouse and touch support.
https://code.makery.ch/library/dart-drag-and-drop/
MIT License
136 stars 91 forks source link

No actually an issue : ported to package:html5 #21

Open dam0vm3nt opened 7 years ago

dam0vm3nt commented 7 years ago

Hi, I've ported your great lib to package:html5 and published to pub.

Just to let you know.

marcojakob commented 7 years ago

Hi @dam0vm3nt. Great! Awesome that you can use it and made a port.

I couldn't find the source code - you're still linking to the original dnd source code in pub. I think it would make sense to link to your version in pub and just leave a link the original source as attribution in the README.

The other option would be to merge your code into the original version. Is it a big change? Is it something different or just an improvement?

dam0vm3nt commented 7 years ago

Ouch! You're right. The code is here, but I'll add it to the readme and pubspec as well.

package:html5 is my experimental alternative html layer that works only on dartdevc and it leverages js-interop. It is slight different from dart:html but there's a chance that dnd can be refactored in a way that makes it work with both. Onestly I was interested only to check if dnd could work with package:html5 (and it works great!), so I did a very rough translation between the two api.

It's working for me but not sure 100% of everything I've changed. If you want you can give it a look.

Anyway thanks for you great work!

marcojakob commented 7 years ago

Nice. Keep us posted how the experiment continues.