Added named routes - Githubissues

marcojanssen / silex-routing-service-provider

Provider for adding routes

MIT License

19 stars 11 forks source link

Added named routes #5

Closed samir-plusb closed 9 years ago

samir-plusb commented 9 years ago

Hi,

I added named routes to the RoutingServiceProvider. It may be related to the following issue: #4

Commit message:

Refactored the RoutingServiceProvider

Implemented named Routes
Added sanitization for named routes
refactored the code
changed the documentation and the composer.json

marcojanssen commented 9 years ago

Very nice, thnx! Will look into it asap

marcojanssen commented 9 years ago

Done with reviewing, would be great if you can make these changes so i can accept it after that

samir-plusb commented 9 years ago

Thank you for the valuable feedback! I made your requested changes and merged/rebased them into one commit (and updated the tag). I also added a new test case...

marcojanssen commented 9 years ago

Looks good, will do some minor refactoring. Thanks for your contribution, will tag it this weekend