search

marcojetson / type-ahead.js

A lightweight and extensible type ahead library
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

Added callback to mousedown on dropdown child #11

Closed therebelrobot closed 9 years ago

therebelrobot commented 9 years ago

Refer #5

therebelrobot commented 9 years ago

uggg. just a sec. missed a console log.

therebelrobot commented 9 years ago

Kk. This should be good to go now.

marcojetson commented 9 years ago

I think this one is going to conflict with the handleKeyDown callback, what if you want to provide different callbacks or only attach to one? IMO we should provide different options with clear names like opts.onMouseDown and opts.onKeyDown.

therebelrobot commented 9 years ago

It didn't seem to cause any issues when I tested it, but it does make sense to separate out the onMouseDown and onKeyDown callbacks. I'll get that change in there.

therebelrobot commented 9 years ago

Kk. Updated that now. Tested in our app, seems to be working.