search

marcojetson / type-ahead.js

A lightweight and extensible type ahead library
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

Allow for setting of limit on object creation #2

Closed therebelrobot closed 9 years ago

therebelrobot commented 9 years ago

Hi @marcojetson! Have to say, I love how simple (and working) your lib is. I'm planning on submitting a PR for this and a few other things I was looking at. Also thinking about a programmatic way to update the candidates (I'll open a separate issue for that though).

What are your thoughts on also having a browserify version for publishing on NPM? I'd be happy to get a PR rolling for that too.

Thanks again for the great lib! Looking at its inclusion into a work project, I'll let you know when it's live for you to see.

marcojetson commented 9 years ago

Hey @therebelrobot, thank you!

I like the idea of being able to setup the input in a single line but I'm afraid of having too many positional parameters. What do you think about providing a settings parameter that allows to override different options using names? The candidates can be moved to that object too.

Having a browserify version is a great idea :)

therebelrobot commented 9 years ago

Yeah, normally for overriding options I just end up supplying an opts object parameter, and if the overriding item is in there it is used. I can work up an example and show you real quick.

I'll get another issue open for browserify then :) I've published a few of those in the past, happy to get it rolling for you.