marcokreeft87 / room-card

Show multiple entity states, attributes and icons in a single card in Home Assistant's Lovelace UI
MIT License
221 stars 36 forks source link

Handle breaking change for ha-icon #313

Closed elupus closed 7 months ago

elupus commented 7 months ago

Which version of Room Card? 1.08.02

Describe the bug A clear and concise description of what the bug is.

Some state icon's are no longer displayed correct.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Correct state icon

Screenshots

image

See bottom left, and bottom right. There should be a outlet icon on the right.

Desktop (please complete the following information):

Additional context

https://developers.home-assistant.io/blog/2024/01/30/ha-state-icon-properties-changes/

YAML

jamesgid-gc commented 7 months ago

I am seeing the same behaviour since updating HA to the latest version. Although the icons are only displaying incorrectly through my web-browser on my desktop computer. On my android phone (Google Pixel 7) the icons are still correct.

room-card version: v1.08.02

Desktop (please complete the following information): OS: Windows 11 Browser Chrome Version 121.0.6167.14

Desktop: image image

Android Phone (and what they looked liked before on the desktop): image image

DeWaHa commented 7 months ago

I have the same problemen on my Android Phone and tablet. The mediaplayer, presence, motion, smoke, co and heat icons are missing.

elupus commented 7 months ago

Did an initial fix attempt here: https://github.com/marcokreeft87/room-card/pull/314 but tests needs to be fixed and the fix needs to be actually tested :)

DeWaHa commented 7 months ago

Hello, Sorry but I don't know how to implement or test the fix. I've got no IT knowledge. Perhaps you can explain me what to do, if it's not to difficult. Hans


From: Joakim Plate @.> Sent: Thursday, February 8, 2024 9:45 AM To: marcokreeft87/room-card @.> Cc: DeWaHa @.>; Comment @.> Subject: Re: [marcokreeft87/room-card] Handle breaking change for ha-icon (Issue #313)

Did an initial fix attempt here: #314https://github.com/marcokreeft87/room-card/pull/314 but tests needs to be fixed and the fix needs to be actually tested :)

— Reply to this email directly, view it on GitHubhttps://github.com/marcokreeft87/room-card/issues/313#issuecomment-1933605783, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYULK2NIZU43WYHD2KWPU6LYSSGEFAVCNFSM6AAAAABC4RBTDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGYYDKNZYGM. You are receiving this because you commented.Message ID: @.***>

TTLucian commented 7 months ago

Same problem here. Icons are all messed up on browser and android app.

Belrix commented 7 months ago

Ditto.

boredomwontgetus commented 7 months ago

+1

marcokreeft87 commented 7 months ago

Seems to be fixed by the change of @elupus Please download the latest version everyone!

calielc commented 7 months ago

It is a beta version 1.08.03 (https://github.com/marcokreeft87/room-card/releases/tag/1.08.03)

DeWaHa commented 7 months ago

How do we install this bèta not using Hacs? Can someone explain please?

TTLucian commented 7 months ago

Got it. For some reason HACS doesn't pick up the update. Go to room card in HACS, hit the 3 dots upper right, click update information then click redownload.

marcokreeft87 commented 7 months ago

It is a beta version 1.08.03 (https://github.com/marcokreeft87/room-card/releases/tag/1.08.03)

No its not?

image

marcokreeft87 commented 7 months ago

HACS is just bugging again as always

DeWaHa commented 7 months ago

Thanks TTLucian and macrokreeft87. Problem solved.

marcokreeft87 commented 7 months ago

Did an initial fix attempt here: https://github.com/marcokreeft87/room-card/pull/314 but tests needs to be fixed and the fix needs to be actually tested :)

Can you confirm it's fixed with the new version?

elupus commented 7 months ago

Did an initial fix attempt here: #314 but tests needs to be fixed and the fix needs to be actually tested :)

Can you confirm it's fixed with the new version?

Yup! Works now. Thanx!